Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/bahir-flink/pull/17#discussion_r128921581
  
    --- Diff: flink-connector-kudu/pom.xml ---
    @@ -0,0 +1,294 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +    <modelVersion>4.0.0</modelVersion>
    +    <groupId>es.accenture</groupId>
    --- End diff --
    
    The whole maven file doesn't seem to be integrated into Bahir's module 
structure.
    
    The licenses, developers an scm sections are not needed because they should 
be inherited from bahir-flink's parent pom.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to