rmetzger commented on a change in pull request #114: URL: https://github.com/apache/bahir-flink/pull/114#discussion_r623013910
########## File path: flink-connector-influxdb2/license-header ########## @@ -0,0 +1,17 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ Review comment: what's the benefit of this file ########## File path: flink-connector-influxdb2/src/main/java/org/apache/flink/streaming/connectors/influxdb/source/InfluxDBSourceBuilder.java ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.streaming.connectors.influxdb.source; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.streaming.connectors.influxdb.source.reader.deserializer.InfluxDBDataPointDeserializer; + +/** + * The @builder class for {@link InfluxDBSource} to make it easier for the users to construct a + * {@link InfluxDBSource}. + * + * <p>The following example shows the minimum setup to create a InfluxDBSource that reads the Long + * values from a line protocol source. + * + * <pre>{@code + * InfluxDBSource<Long> influxDBSource = InfluxBSource.builder() + * .setDeserializer(new InfluxDBDeserializer()) + * .build() + * }</pre> + * + * <p>To specify the starting port on which the InfluxDBSource starts its HTTP server, one can call + * {@link #setPort(int)}. + * + * <p>Check the Java docs of each individual methods to learn more about the settings to build a + * InfluxDBSource. + */ +public final class InfluxDBSourceBuilder<OUT> { + + private InfluxDBDataPointDeserializer<OUT> deserializationSchema; + // Configurations Review comment: not: this comment is not really adding value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
