i3wangyi commented on issue #408: Improve equals() on config objects URL: https://github.com/apache/helix/pull/408#issuecomment-521825255 It'd be better to write some unit tests to justify - cases where original equals won't work but it should - cases with your change, the equals method works
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org