narendly commented on a change in pull request #490: DRAFT: Add the metric
components for WAGED rebalancer
URL: https://github.com/apache/helix/pull/490#discussion_r329383516
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -255,11 +261,14 @@ private void
refreshBaseline(ResourceControllerDataProvider clusterData,
Map<HelixConstants.ChangeType, Set<String>> clusterChanges, Map<String,
Resource> resourceMap,
final CurrentStateOutput currentStateOutput) throws
HelixRebalanceException {
LOG.info("Start calculating the new best possible assignment.");
+ LatencyMetric partialRebalanceMetric = new
PartialRebalanceMetric("PartialRebalanceLatency");
+ _metricCollector.addMetric(partialRebalanceMetric);
Review comment:
I agree. Let's go the direction of defining and adding all metrics in the
beginning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
