kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377986596
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/api/factory/RealmAwareZkClientFactory.java
##########
@@ -19,5 +19,14 @@
* under the License.
*/
+import org.apache.helix.zookeeper.api.api.client.RealmAwareZkClient;
+
+
+/**
+ * Creates an instance of RealmAwareZkClient.
+ */
public interface RealmAwareZkClientFactory {
+
+ RealmAwareZkClient buildZkClient(RealmAwareZkClient.MODE mode,
Review comment:
mode is redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
