kaisun2000 commented on a change in pull request #745: Add RealmAwareZkClient
and RealmAwareZkClientFactory interfaces
URL: https://github.com/apache/helix/pull/745#discussion_r379057281
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/factory/RealmAwareZkClientFactory.java
##########
@@ -19,5 +19,13 @@
* under the License.
*/
+import org.apache.helix.zookeeper.api.client.RealmAwareZkClient;
+
+
+/**
+ * Creates an instance of RealmAwareZkClient.
+ */
public interface RealmAwareZkClientFactory {
+ RealmAwareZkClient
buildZkClient(RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
Review comment:
To achieve feature parity of HelixZkClientInterface, shall we add this
constructor too?
` public RealmAwareZkClient buildZkClient(
RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig) {
return buildZkClient(connectConfig, new
RealmAwareZkClient.RealmAwareZkClientConfig());
}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
