pkuwm commented on a change in pull request #851: Add customized view computation and modify Helix generic controller to include new stage URL: https://github.com/apache/helix/pull/851#discussion_r394041792
########## File path: helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregateStage.java ########## @@ -0,0 +1,171 @@ +package org.apache.helix.controller.stages; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import org.apache.helix.HelixDataAccessor; +import org.apache.helix.HelixException; +import org.apache.helix.HelixManager; +import org.apache.helix.PropertyKey; +import org.apache.helix.common.caches.CustomizedViewCache; +import org.apache.helix.controller.LogUtil; +import org.apache.helix.controller.dataproviders.ResourceControllerDataProvider; +import org.apache.helix.controller.pipeline.AbstractAsyncBaseStage; +import org.apache.helix.controller.pipeline.AsyncWorkerType; +import org.apache.helix.controller.pipeline.StageException; +import org.apache.helix.model.CustomizedView; +import org.apache.helix.model.Partition; +import org.apache.helix.model.Resource; +import org.apache.helix.monitoring.mbeans.ClusterStatusMonitor; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class CustomizedViewAggregateStage extends AbstractAsyncBaseStage { + private static Logger LOG = LoggerFactory.getLogger(CustomizedViewAggregateStage.class); + + @Override + public AsyncWorkerType getAsyncWorkerType() { + return AsyncWorkerType.CustomizedStateViewComputeWorker; + } + + @Override + public void execute(final ClusterEvent event) throws Exception { Review comment: The implementation in this method is too long. Can we try to split it into several private methods like: ``` removeStaleTypes() updateCustomizedView() ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
