jiajunwang commented on a change in pull request #851: Modify Helix generic
controller to include new stage for customized view aggregation
URL: https://github.com/apache/helix/pull/851#discussion_r394680179
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -431,16 +443,31 @@ private static PipelineRegistry
createDefaultRegistry(String pipelineName) {
Pipeline autoExitMaintenancePipeline = new Pipeline(pipelineName);
autoExitMaintenancePipeline.addStage(new MaintenanceRecoveryStage());
- registry.register(ClusterEventType.IdealStateChange, dataRefresh,
dataPreprocess, rebalancePipeline);
- registry.register(ClusterEventType.CurrentStateChange, dataRefresh,
dataPreprocess, externalViewPipeline, rebalancePipeline);
- registry.register(ClusterEventType.InstanceConfigChange, dataRefresh,
dataPreprocess, rebalancePipeline);
- registry.register(ClusterEventType.ResourceConfigChange, dataRefresh,
dataPreprocess, rebalancePipeline);
- registry.register(ClusterEventType.ClusterConfigChange, dataRefresh,
autoExitMaintenancePipeline, dataPreprocess, rebalancePipeline);
- registry.register(ClusterEventType.LiveInstanceChange, dataRefresh,
autoExitMaintenancePipeline, liveInstancePipeline, dataPreprocess,
externalViewPipeline, rebalancePipeline);
- registry.register(ClusterEventType.MessageChange, dataRefresh,
dataPreprocess, rebalancePipeline);
- registry.register(ClusterEventType.Resume, dataRefresh, dataPreprocess,
externalViewPipeline, rebalancePipeline);
- registry.register(ClusterEventType.PeriodicalRebalance, dataRefresh,
autoExitMaintenancePipeline, dataPreprocess, externalViewPipeline,
rebalancePipeline);
- registry.register(ClusterEventType.OnDemandRebalance, dataRefresh,
autoExitMaintenancePipeline, dataPreprocess, externalViewPipeline,
rebalancePipeline);
+ registry.register(ClusterEventType.IdealStateChange, dataRefresh,
dataPreprocess,
+ rebalancePipeline);
+ registry.register(ClusterEventType.CurrentStateChange, dataRefresh,
dataPreprocess,
+ externalViewPipeline, rebalancePipeline);
+ registry.register(ClusterEventType.InstanceConfigChange, dataRefresh,
dataPreprocess,
+ rebalancePipeline);
+ registry.register(ClusterEventType.ResourceConfigChange, dataRefresh,
dataPreprocess,
+ rebalancePipeline);
+ registry.register(ClusterEventType.ClusterConfigChange, dataRefresh,
+ autoExitMaintenancePipeline, dataPreprocess, rebalancePipeline);
+ registry.register(ClusterEventType.LiveInstanceChange, dataRefresh,
+ autoExitMaintenancePipeline, liveInstancePipeline, dataPreprocess,
externalViewPipeline, customizedViewPipeline,
+ rebalancePipeline);
+ registry.register(ClusterEventType.MessageChange, dataRefresh,
dataPreprocess,
+ rebalancePipeline);
+ registry.register(ClusterEventType.Resume, dataRefresh, dataPreprocess,
externalViewPipeline,
+ rebalancePipeline);
+ registry.register(ClusterEventType.PeriodicalRebalance, dataRefresh,
+ autoExitMaintenancePipeline, dataPreprocess, externalViewPipeline,
rebalancePipeline);
+ registry.register(ClusterEventType.OnDemandRebalance, dataRefresh,
+ autoExitMaintenancePipeline, dataPreprocess, externalViewPipeline,
rebalancePipeline);
+ registry.register(ClusterEventType.CustomizedStateChange, dataRefresh,
dataPreprocess,
Review comment:
The issue has been resolved with rebalancePipeline at the end. Please add a
TODO here to note it is not efficient, and we should improve this by splitting
the pipeline or controller roles to multiple hosts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
