alirezazamani commented on a change in pull request #869: Replace customized
view cache with property cache
URL: https://github.com/apache/helix/pull/869#discussion_r399837189
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/CustomizedViewCache.java
##########
@@ -19,32 +19,24 @@
* under the License.
*/
-import java.util.ArrayList;
import java.util.Collections;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
import java.util.Map;
-import java.util.Set;
import org.apache.helix.HelixDataAccessor;
-import org.apache.helix.HelixException;
import org.apache.helix.PropertyKey;
import org.apache.helix.PropertyType;
import org.apache.helix.model.CustomizedView;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.common.collect.Maps;
/**
* Cache to hold all CustomizedView of a specific type.
*/
public class CustomizedViewCache extends AbstractDataCache<CustomizedView> {
private static final Logger LOG =
LoggerFactory.getLogger(CustomizedViewCache.class.getName());
- protected Map<String, CustomizedView> _customizedViewMap;
- protected Map<String, CustomizedView> _customizedViewCache;
+ private final PropertyCache<CustomizedView> _customizedViewCache;
Review comment:
I chatted with Meng about this. Since both of our PRs has been implemented
based on this file, I think it makes more sense to have separate file for
customizedViewCache and have it implemented based on PropertyCache as discussed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
