xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1072893104
########## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java: ########## @@ -1121,4 +1120,13 @@ public long getPendingStateTransitionGuage() { } return total; } + + @Override + public long getRebalanceThrottledByErrorPartition() { + long total = 0; + for (Map.Entry<String, ResourceMonitor> entry : _resourceMonitorMap.entrySet()) { Review Comment: IMHO, lamda is slower. Probably we want better performance in functions being called rapidly. (1/min) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org