rahulrane50 commented on code in PR #2344: URL: https://github.com/apache/helix/pull/2344#discussion_r1084398651
########## helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java: ########## @@ -319,12 +322,17 @@ private void reportTopStateHandoffFailIfNecessary(ResourceControllerDataProvider String partitionName = partition.getPartitionName(); MissingTopStateRecord record = missingTopStateMap.get(resourceName).get(partitionName); long startTime = record.getStartTimeStamp(); - if (startTime > 0 && System.currentTimeMillis() - startTime > durationThreshold && !record + if (startTime > 0 && !record .isFailed()) { Review Comment: Sure let me fix indentation. But this is not refactoring and needed for this fix (need to update map irrespective of threshold). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org