zpinto commented on code in PR #2776:
URL: https://github.com/apache/helix/pull/2776#discussion_r1524049443
##########
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java:
##########
@@ -462,14 +461,5 @@ public DryrunWagedRebalancer(ZkBucketDataAccessor
zkBucketDataAccessor, String c
Map<ClusterConfig.GlobalRebalancePreferenceKey, Integer> preferences) {
super(zkBucketDataAccessor, clusterName, preferences);
}
-
- @Override
- protected Map<String, ResourceAssignment> computeBestPossibleAssignment(
- ResourceControllerDataProvider clusterData, Map<String, Resource>
resourceMap,
- Set<String> activeNodes, CurrentStateOutput currentStateOutput,
- RebalanceAlgorithm algorithm) throws HelixRebalanceException {
- return getBestPossibleAssignment(getAssignmentMetadataStore(),
currentStateOutput,
- resourceMap.keySet());
- }
Review Comment:
Discussed offline. TLDR, we need to remove this to consider the
handleDelayedRebalanceMinActiveReplica changes to the idealState which are not
persisted to BEST_POSSIBLE in assignment metadatastore. Will add javadoc to
this verifier to clarify the expected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
