Hello Lars Volker, Philip Zeyliger, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8546
to look at the new patch set (#3).
Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo
......................................................................
IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo
Running shell commands from impalad can be problematic, because using popen
leads
to forking which causes a spike in virtual memory. To avoid this, "ls" is
replaced
with Posix api calls.
FileDescriptorMap fd_desc_ was only used to get the number of file descriptors,
so
it was unneccesery work to initialize it. It is removed, and only the number of
file
descriptors is computed.
The automatic test for this function is only a sanity check, because there is
no
way to know the "expected value" in advance, and the number of file desciptors
can
change anytime.
Change-Id: Ibffae8069a62e100abbfa7d558b49040b095ddc0
---
M be/src/util/proc-info-test.cc
M be/src/util/process-state-info.cc
M be/src/util/process-state-info.h
3 files changed, 16 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/8546/3
--
To view, visit http://gerrit.cloudera.org:8080/8546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibffae8069a62e100abbfa7d558b49040b095ddc0
Gerrit-Change-Number: 8546
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
