Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 )
Change subject: IMPALA-6206: Fix data load failure with -notests ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8580/2/be/src/udf_samples/CMakeLists.txt File be/src/udf_samples/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/8580/2/be/src/udf_samples/CMakeLists.txt@44 PS2, Line 44: # Data loading depends on building these targets > This feels a little weird since those targets aren't really part of the Imp I felt the same way but didn't want to clutter things with more targets, so I lazily re-used an existing one. I'll make a proper top-level target instead. -- To view, visit http://gerrit.cloudera.org:8080/8580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa193989d77d56b72db05ad54e1fb0a345938fb Gerrit-Change-Number: 8580 Gerrit-PatchSet: 2 Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Fri, 17 Nov 2017 19:10:01 +0000 Gerrit-HasComments: Yes
