Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8500 )
Change subject: Pin gen_build_version's git handling to typical git dir. ...................................................................... Pin gen_build_version's git handling to typical git dir. gen_build_version.py now specifies --git-dir explicitly, to avoid fetching the revision of a containing git directory that's not an Impala checkout. This came up when building Impala without a git directory, but within a build system that happens to have a git directory higher up in the directory tree. I tested this by running the script manually and observing it works identically in the normal case. Change-Id: I98870a1cb2073ddcf9ba1620e3801e1964930edd Reviewed-on: http://gerrit.cloudera.org:8080/8500 Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com> Tested-by: Impala Public Jenkins --- M bin/gen_build_version.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I98870a1cb2073ddcf9ba1620e3801e1964930edd Gerrit-Change-Number: 8500 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com>
