Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 )
Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/8510/7/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/8510/7/be/src/util/openssl-util.cc@147 PS7, Line 147: return (SSLeay() >= OPENSSL_VERSION_1_0_1); When we re-do this patch we should also add a test option to force use of CFB mode and make sure that the unit test tests both encryption modes. -- To view, visit http://gerrit.cloudera.org:8080/8510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib97939f2334838263364b53ef3413871638bf53e Gerrit-Change-Number: 8510 Gerrit-PatchSet: 7 Gerrit-Owner: Xianda Ke <kexia...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Mike Yoder <myo...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Xianda Ke <kexia...@gmail.com> Gerrit-Comment-Date: Mon, 20 Nov 2017 17:57:30 +0000 Gerrit-HasComments: Yes
