Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 )
Change subject: IMPALA-5019: Decimal V2 addition ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8309/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/8309/4/be/src/exprs/expr-test.cc@a2402 PS4, Line 2402: > Still not following. The old V2 expected value was 999.6 not 999.5. Regarding the first point: the type of "power(10, 3) - 0.45" in decimal v2 before this patch is decimal(38, 17). the type of "power(10, 3) - 0.45" in decimal v2 after this patch is decimal(38, 16). This causes the result of the conversion to double to be slightly different. Before this patch (in decimal v2) after converting to double it looks like this: 999.5500156861889 After this patch, it looks like this: 999.5499727558438 This is why the result was 999.5 and not 999.6 after the patch. This is all due to IMPALA-6183, which was fixed (and is reflected in the latest patch). -- To view, visit http://gerrit.cloudera.org:8080/8309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I401049c56d910eb1546a178c909c923b01239336 Gerrit-Change-Number: 8309 Gerrit-PatchSet: 4 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Nov 2017 21:34:17 +0000 Gerrit-HasComments: Yes
