Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 )
Change subject: IMPALA-4927: Impala should handle invalid input from Sentry ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8588/5/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/8588/5/fe/src/main/java/org/apache/impala/util/SentryProxy.java@146 PS5, Line 146: AuthorizationException > I'm not sure I agree with Bharath. We don't catch generic exceptions (like While I agree that catching a generic Exception is a bad practice, my point was that the projects we rely on have a habit of breaking APIs. Reason being, there is no way to enforce the API contracts, except to realize after a third party upgrade that things start failing to compile. That said, I'm fine if we catch very specific Exception for this particular case, if everyone else thinks that's a better idea. Pranay, sorry for the back and forth. -- To view, visit http://gerrit.cloudera.org:8080/8588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I781411018d580854d80a9cad81a1ded7ca16af8b Gerrit-Change-Number: 8588 Gerrit-PatchSet: 5 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:23:32 +0000 Gerrit-HasComments: Yes
