Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8614 )
Change subject: IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8614/3/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/8614/3/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java@249 PS3, Line 249: if (distinctAggExprs.get(i).getFnName().getFunction().equalsIgnoreCase( : "count")) { > That's correct, but that error message is also thrown for non-count(distinc 1. Do you mean the guidance of NDV is also printed on your example? Why should we do this? If a given query does not have any use case of COUNT(DISTINCT), we don't have to display this. It could make an user confuse. May I know your intention why we should include this? -- To view, visit http://gerrit.cloudera.org:8080/8614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5084be10946d68f3ec0760c2b7e698635df26a89 Gerrit-Change-Number: 8614 Gerrit-PatchSet: 3 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Wed, 22 Nov 2017 05:48:55 +0000 Gerrit-HasComments: Yes
