Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 )
Change subject: IMPALA-2181: Add query option levels for display ...................................................................... Patch Set 19: (4 comments) http://gerrit.cloudera.org:8080/#/c/8447/18/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/8447/18/be/src/service/query-options.h@113 PS18, Line 113: QUERY_OPT_FN(strict_mode, STRICT_MODE, TQueryOptionLevel::DEVELOPMENT)\ > per discussion on the JIRA, I think this should be under DEVELOPMENT until Done http://gerrit.cloudera.org:8080/#/c/8447/18/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/8447/18/shell/impala_client.py@100 PS18, Line 100: hasattr(option, 'level') and > This check shouldn't be necessary, right? Unless you're doing what I did an in theory, if the shell with the feature comes from an Impala that is compiled than this is not necessary. I would still keep it be make 100% sure, that nothing breaks if you don't mind. http://gerrit.cloudera.org:8080/#/c/8447/18/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8447/18/shell/impala_shell.py@83 PS18, Line 83: correspond > correspond Done http://gerrit.cloudera.org:8080/#/c/8447/18/shell/impala_shell.py@242 PS18, Line 242: # If the shell is connected to an Impala that predates IMPALA-2181 then > This is subtle - can you add a comment? If I understand correctly, this is Done -- To view, visit http://gerrit.cloudera.org:8080/8447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75720d0d454527e1a0ed19bb43cf9e4f018ce1d1 Gerrit-Change-Number: 8447 Gerrit-PatchSet: 19 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 22 Nov 2017 19:45:46 +0000 Gerrit-HasComments: Yes
