Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8639
Change subject: IMPALA-4664: Unexpected string conversion in Shell ...................................................................... IMPALA-4664: Unexpected string conversion in Shell Impala shell can accidentally convert certain literal strings to lowercase. Impala shell splits each command into tokens and then converts the first token to lowercase to figure out how it should execute the command. The splitting is done by spaces only. Thus, if the user types a TAB after the SELECT, the first token after the split becomes the SELECT plus whatever comes after it. Using sqlparse library in infra instead of shell/ext-py/sqlparse-0.1.14. The sqlparse library in infra is upgraded from 0.1.15 to 0.2.4 due to bug fixes and syntax extension. Testing: Add tests to tests/shell/test_shell_interactive.py Change-Id: Iba6fa4e9ac570d22135ba51b844db8f9be965ca3 --- M LICENSE.txt M README.md M bin/rat_exclude_files.txt M infra/python/deps/requirements.txt M shell/.gitignore D shell/ext-py/sqlparse-0.1.14/AUTHORS D shell/ext-py/sqlparse-0.1.14/CHANGES D shell/ext-py/sqlparse-0.1.14/COPYING D shell/ext-py/sqlparse-0.1.14/MANIFEST.in D shell/ext-py/sqlparse-0.1.14/PKG-INFO D shell/ext-py/sqlparse-0.1.14/README.rst D shell/ext-py/sqlparse-0.1.14/TODO D shell/ext-py/sqlparse-0.1.14/bin/sqlformat D shell/ext-py/sqlparse-0.1.14/docs/source/analyzing.rst D shell/ext-py/sqlparse-0.1.14/docs/source/api.rst D shell/ext-py/sqlparse-0.1.14/docs/source/changes.rst D shell/ext-py/sqlparse-0.1.14/docs/source/conf.py D shell/ext-py/sqlparse-0.1.14/docs/source/index.rst D shell/ext-py/sqlparse-0.1.14/docs/source/indices.rst D shell/ext-py/sqlparse-0.1.14/docs/source/intro.rst D shell/ext-py/sqlparse-0.1.14/docs/source/ui.rst D shell/ext-py/sqlparse-0.1.14/docs/sqlformat.1 D shell/ext-py/sqlparse-0.1.14/pytest.ini D shell/ext-py/sqlparse-0.1.14/setup.cfg D shell/ext-py/sqlparse-0.1.14/setup.py D shell/ext-py/sqlparse-0.1.14/sqlparse/__init__.py D shell/ext-py/sqlparse-0.1.14/sqlparse/engine/__init__.py D shell/ext-py/sqlparse-0.1.14/sqlparse/engine/filter.py D shell/ext-py/sqlparse-0.1.14/sqlparse/engine/grouping.py D shell/ext-py/sqlparse-0.1.14/sqlparse/exceptions.py D shell/ext-py/sqlparse-0.1.14/sqlparse/filters.py D shell/ext-py/sqlparse-0.1.14/sqlparse/formatter.py D shell/ext-py/sqlparse-0.1.14/sqlparse/functions.py D shell/ext-py/sqlparse-0.1.14/sqlparse/keywords.py D shell/ext-py/sqlparse-0.1.14/sqlparse/lexer.py D shell/ext-py/sqlparse-0.1.14/sqlparse/pipeline.py D shell/ext-py/sqlparse-0.1.14/sqlparse/sql.py D shell/ext-py/sqlparse-0.1.14/sqlparse/tokens.py D shell/ext-py/sqlparse-0.1.14/sqlparse/utils.py D shell/ext-py/sqlparse-0.1.14/tests/__init__.py D shell/ext-py/sqlparse-0.1.14/tests/files/_Make_DirEntry.sql D shell/ext-py/sqlparse-0.1.14/tests/files/begintag.sql D shell/ext-py/sqlparse-0.1.14/tests/files/begintag_2.sql D shell/ext-py/sqlparse-0.1.14/tests/files/dashcomment.sql D shell/ext-py/sqlparse-0.1.14/tests/files/function.sql D shell/ext-py/sqlparse-0.1.14/tests/files/function_psql.sql D shell/ext-py/sqlparse-0.1.14/tests/files/function_psql2.sql D shell/ext-py/sqlparse-0.1.14/tests/files/function_psql3.sql D shell/ext-py/sqlparse-0.1.14/tests/files/huge_select.sql D shell/ext-py/sqlparse-0.1.14/tests/files/test_cp1251.sql D shell/ext-py/sqlparse-0.1.14/tests/test_filters.py D shell/ext-py/sqlparse-0.1.14/tests/test_format.py D shell/ext-py/sqlparse-0.1.14/tests/test_functions.py D shell/ext-py/sqlparse-0.1.14/tests/test_grouping.py D shell/ext-py/sqlparse-0.1.14/tests/test_parse.py D shell/ext-py/sqlparse-0.1.14/tests/test_pipeline.py D shell/ext-py/sqlparse-0.1.14/tests/test_regressions.py D shell/ext-py/sqlparse-0.1.14/tests/test_split.py D shell/ext-py/sqlparse-0.1.14/tests/test_tokenize.py D shell/ext-py/sqlparse-0.1.14/tests/utils.py D shell/ext-py/sqlparse-0.1.14/tox.ini M shell/impala_shell.py M tests/shell/test_shell_interactive.py 63 files changed, 37 insertions(+), 6,715 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/8639/1 -- To view, visit http://gerrit.cloudera.org:8080/8639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iba6fa4e9ac570d22135ba51b844db8f9be965ca3 Gerrit-Change-Number: 8639 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com>
