Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page ...................................................................... Patch Set 1: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/8648/1/docs/impala_keydefs.ditamap File docs/impala_keydefs.ditamap: http://gerrit.cloudera.org:8080/#/c/8648/1/docs/impala_keydefs.ditamap@10521 PS1, Line 10521: <!-- Note: needs to be updated once for each Impala release. --> : <keydef keys="impala_current_version"><topicmeta><keywords><keyword>2.10</keyword></keywords></topicmeta></keydef> I respect your desire to fix this, but there is a maintenance cost in doing this: someone has to remember to set this version. Note that bin/save-version.sh is the canonical place the Impala version is set. When we have it in two places, people don't always update both places. I'm working on seeing if I can incorporate a bin/save-version.sh call into the docs build. -- To view, visit http://gerrit.cloudera.org:8080/8648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2 Gerrit-Change-Number: 8648 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Laurel Hale <lau...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Nov 2017 21:00:24 +0000 Gerrit-HasComments: Yes
