John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8654 )
Change subject: [DOCS] include version when building ...................................................................... Patch Set 1: I'm not going to have time to think this through in detail today. I have on my backburner to make some general enhancements to the Makefile, e.g. some more phony targets to build, XML validate, etc. combinations of things. In general, I would like to keep a checked-in version of impala_keydefs.ditamap so that there was always a way to do a single 'dita ...' command to run a build for basic proofreading, even if the production-ready technique went through extra steps. I think the <keydef> tag I added in https://gerrit.cloudera.org/#/c/8648/ could serve as the placeholder if desired. We could keep a dummy value in the source file and always substitute during the build. Although... there's where I would need more time to look through the suggestion and think through how it matches with the current scheme. -- To view, visit http://gerrit.cloudera.org:8080/8654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2036993636c8f73c07790bd4bdf4da0b721549a Gerrit-Change-Number: 8654 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Laurel Hale <lau...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Nov 2017 23:58:12 +0000 Gerrit-HasComments: No
