Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8652 )
Change subject: IMPALA-6241: timeout in admission control test under ASAN ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/8652/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8652/1//COMMIT_MSG@10 PS1, Line 10: : While testing that fix, I discovered that the ASAN build detection logic : was failing silently > Sorry to hear this wasn't working. Thanks for making an improvement. It looks like it was my bug that caused it to fail actually :) (it's unfortunate that the silent nature of the failure caused us to go this long without noticing it though). http://gerrit.cloudera.org:8080/#/c/8652/1/infra/python/deps/requirements.txt File infra/python/deps/requirements.txt: http://gerrit.cloudera.org:8080/#/c/8652/1/infra/python/deps/requirements.txt@45 PS1, Line 45: monkeypatch == 0.1rc3 > I don't think anything else is using this, so it can be removed. Done http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py File tests/common/environ.py: http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@a198 PS1, Line 198: > I guess the bug is that this should have been elif. Oops, that is my bug then - I didn't see this when looking at the code. It doesn't seem like the changed approach really directly addresses the bug then. http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@19 PS1, Line 19: import pytest > Unused; remove. Done http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@112 PS1, Line 112: is_dev > Do you want to add ubsan to this method? Done http://gerrit.cloudera.org:8080/#/c/8652/1/tests/common/environ.py@122 PS1, Line 122: runs_slowly > Do you want to add ubsan to this method? Done -- To view, visit http://gerrit.cloudera.org:8080/8652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536 Gerrit-Change-Number: 8652 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Nov 2017 01:20:08 +0000 Gerrit-HasComments: Yes
