Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 )
Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8623/1/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: http://gerrit.cloudera.org:8080/#/c/8623/1/be/src/exec/hdfs-scanner.h@333 PS1, Line 333: If template tuple is not NULL > Actually the null case is common for count(*) of course. So, maybe we shoul PS3 reverted to the existing behavior of leaving those tuple_ptrs uninitialized. http://gerrit.cloudera.org:8080/#/c/8623/2/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8623/2/be/src/exec/hdfs-scanner.cc@226 PS2, Line 226: > This seems to violate the invariant that the scan node only produces non-NU PS3 reverted to the existing behavior for now. I think setting it to some dummy non-NULL pointer is the way to go but I will punt on doing it in this patch until we can come up with an example for the potential problem you describe. http://gerrit.cloudera.org:8080/#/c/8623/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/8623/2/be/src/runtime/row-batch.cc@60 PS2, Line 60: tuple_ptrs_ = reinterpret_cast<Tuple**>(malloc(tuple_ptrs_size_)); > I don't think we should zero-initialise this. We can't depend on the tuple_ Reverted to the existing behavior in PS3. -- To view, visit http://gerrit.cloudera.org:8080/8623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib530f1fdcd2c6de699977db163b3f6eb38481517 Gerrit-Change-Number: 8623 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Nov 2017 20:40:06 +0000 Gerrit-HasComments: Yes