Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#5). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads ...................................................................... IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads The KuduRPC subsystem uses kudu::ServicePool to service all incoming RPCs. Since this lives inside the Kudu codebase, all instrumentation of RPCs flowing through the KuduRPC subsystem is not visible to Impala, as Kudu does not export this instrumentation, but only maintains it internally within kudu::ServicePool. In order to reliably view the instrumentation of all RPCs flowing through KRPC, one option is to modify kudu::ServicePool to take their instrumentation and display it on our webpages, which is very invasive. A second option is to have a parallel implementation of kudu::ServicePool which for all purposes behaves the same way, but instead has this extra code that displays this instrumentation in our webpages. This patch is Part 2 of the second option. In Part 1, we simply copied the code from kudu::ServicePool into the Impala namespace. In this patch, we rename the redundant kudu::ServicePool (that was copied into be/src/rpc/) to ImpalaServicePool. We also expose the instrumentaion of the ImpalaServicePool as JSON. Now, the threads in use by the service pool will also be visible in the /threadz page. This patch however does not display instrumentation on the Webpages yet. In a future patch, we will add that through the ImpalaServicePool and the RpcMgr. Tracked by IMPALA-6269 This patch is partially based on an abandoned patch by Henry Robinson. Change-Id: Ia3e0fa9ae22c4803b0cea736eb35e333e2671448 --- M be/src/rpc/CMakeLists.txt M be/src/rpc/impala-service-pool.cc M be/src/rpc/impala-service-pool.h M be/src/rpc/rpc-mgr.cc M be/src/rpc/rpc-mgr.h M be/src/rpc/rpc-trace.h 6 files changed, 116 insertions(+), 138 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8472/5 -- To view, visit http://gerrit.cloudera.org:8080/8472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia3e0fa9ae22c4803b0cea736eb35e333e2671448 Gerrit-Change-Number: 8472 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>