Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 )
Change subject: IMPALA-6232: Disable file handle cache by default ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8750/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8750/1/be/src/runtime/io/disk-io-mgr.cc@96 PS1, Line 96: // or smaller, depending on the replication factor for this file or the path name. > Maybe add a TODO to re-enable it? Added a TODO http://gerrit.cloudera.org:8080/#/c/8750/1/be/src/runtime/io/disk-io-mgr.cc@109 PS1, Line 109: DEFINE_uint64(unused_file_handle_timeout_sec, 270, "Maximum time, in seconds, that an " > Maybe also mention here why you chose 270 (I see there's an explanation in Added some explanation. -- To view, visit http://gerrit.cloudera.org:8080/8750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea7f943f63b72b42286a9e8b9987308baa79d7b0 Gerrit-Change-Number: 8750 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Dec 2017 22:06:11 +0000 Gerrit-HasComments: Yes
