Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8765 to look at the new patch set (#2). Change subject: IMPALA-6273: fixes subquery tests for functional_hbase ...................................................................... IMPALA-6273: fixes subquery tests for functional_hbase IMPALA-1422 introduced tests that do not work with the testing setup for hbase. Namely, tinyinttable is not defined in the functional_hbase database, but is defined in the functional database. Exhaustive tests uncovered the issue. This change makes two changes so that tests work with functional_hbase: 1) use a table that is present in both functional and functional_hbase. the tests needed a subquery result with a single int column. tinyinttable is replaced with an inline view that provides this single int column in a portable manner. 2) nulls are handled differently with hbase (see IMPALA-728) so the nulltable used in the tests is set to functional.nulltable to avoid inconsistent results across input formats. Testing: - ran e2e tests with exhaustive exploration strategy for the broken test. Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0 --- M testdata/workloads/functional-query/queries/QueryTest/subquery-in-constant-lhs.test 1 file changed, 17 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8765/2 -- To view, visit http://gerrit.cloudera.org:8080/8765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0 Gerrit-Change-Number: 8765 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>