Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8763 )
Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" ...................................................................... Patch Set 2: > I would recommend against reverting this entire change for the > following reasons: > > - this doesn't break anything on asf-master if KRPC is not enabled. > - Our testing with this patch with KRPC enabled has been fine and > not hit this problem in the secure cluster. > - It's unclear if this is a specific issue related to the test > setup (e.g. the way we set up minikdc). > - reverting this change will block continuous testing of KRPC. > > Due to the above, I would recommend only disabling the offending BE > test for now. I've mentioned the reason for the problem in IMPALA-6268. This basically would break for KRPC w/ kerberos on any system with kerberos 1.10 or below, due to a kerberos bug in those versions. It's not just a test failure, which is why I reverted the entire patch instead of disabling the test. But if you think we can keep the patch in for testing purposes while just disabling the test till we find a fix, I'm fine with that too. Let me know what you think. -- To view, visit http://gerrit.cloudera.org:8080/8763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e17d35fa7000bda9aeb8bf2ef950df9d355a9c5 Gerrit-Change-Number: 8763 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Dec 2017 18:58:19 +0000 Gerrit-HasComments: No
