Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8790
Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' ...................................................................... IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' Previously, CodegenAnyVal used an LLVM function for floating point comparison that considered 'nan' = 'nan' to be true. This is inconsistent with the way we handle 'nan' in the non-codegen path, where we consider 'nan' = 'nan' to be false, leading to inconsisent results. This patch fixes CodegenAnyVal to use an LLVM function for floating point comparison that considers 'nan' = 'nan' to be false. Testing: - Added e2e tests for the two scenarios affected by this: CASE and joins. Change-Id: I1bb8e5074b3c939927dedc46bc9db63ca24486a1 --- M be/src/codegen/codegen-anyval.cc M testdata/workloads/functional-query/queries/QueryTest/exprs.test M testdata/workloads/functional-query/queries/QueryTest/joins.test 3 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/8790/1 -- To view, visit http://gerrit.cloudera.org:8080/8790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1bb8e5074b3c939927dedc46bc9db63ca24486a1 Gerrit-Change-Number: 8790 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
