Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 )
Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8784/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8784/1/tests/query_test/test_observability.py@119 PS1, Line 119: __ > Why __ prefix ? I meant this as a way to convey that this function is 'private', and is not a test case that is exposed. Suggestions for alternatives welcome! http://gerrit.cloudera.org:8080/#/c/8784/1/tests/query_test/test_observability.py@136 PS1, Line 136: while (retries < 60): > for i in xrange(MAX_RETRIES): Done http://gerrit.cloudera.org:8080/#/c/8784/1/tests/query_test/test_observability.py@139 PS1, Line 139: ["Start Time" > Is this key always in info_strings[] ? Is there a chance this will result i I think the keys are always there, unless they are removed from ClientRequestState::ClientRequestState() and ClientRequestState::Done(). We'd be able to catch the regression then. Since clients expect to see these, I think it's good to assume so in the test case as well. http://gerrit.cloudera.org:8080/#/c/8784/1/tests/query_test/test_observability.py@140 PS1, Line 140: ["End Time"] > Same question for "End Time". See the previous reply. -- To view, visit http://gerrit.cloudera.org:8080/8784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3421a34cc029ebca551730084c7cbd402d5c109 Gerrit-Change-Number: 8784 Gerrit-PatchSet: 1 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Dec 2017 20:07:46 +0000 Gerrit-HasComments: Yes
