Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8796
Change subject: IMPALA-6292: Fix incorrect DCHECK in decimal subtraction ...................................................................... IMPALA-6292: Fix incorrect DCHECK in decimal subtraction When subtracting two decimals, and one of them is large, we incorrectly hit a DCHECK if the intermediate result was equal to 10^39-1, which is MAX_UNSCALED_DECIMAL16. We fix the problem by changing the condition in the DCHECK from "less than" to "less than or equal to". Testing: - Added expr tests that reproduce the issue. Change-Id: I42d42ad85efe32b7a0db0d2353385939fee09934 --- M be/src/exprs/expr-test.cc M be/src/runtime/decimal-value.inline.h 2 files changed, 19 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/8796/1 -- To view, visit http://gerrit.cloudera.org:8080/8796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I42d42ad85efe32b7a0db0d2353385939fee09934 Gerrit-Change-Number: 8796 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
