Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 )
Change subject: IMPALA-6286: Remove invalid runtime filter targets. ...................................................................... Patch Set 7: Code-Review+1 (3 comments) thanks for the explanation... looks fine to me. http://gerrit.cloudera.org:8080/#/c/8783/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/8783/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1491 PS6, Line 1491: d nit: predicates http://gerrit.cloudera.org:8080/#/c/8783/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1533 PS6, Line 1533: isTrueWithNullSlots > The predicates generated in this function are for optimization purposes and ok, that's what I was looking for. for runtime filter and dictionary pruning, they're clearly for optimization purposes so skipping is easy to reason about. its unclear for this method (getBoundPredicates)-- that a caller can expect some predicates to not be bound due to env/runtime issues. In particular, the previous behavior would have aborted this query, right? In which case, I'd expect additional queries to run with this change. http://gerrit.cloudera.org:8080/#/c/8783/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1923 PS6, Line 1923: } > Btw, I plan to add new targeted tests for these expr evaluation failure cas makes sense-- we should then see the BE failure for TupleIsNullPredicate instead of the assertion failure... didn't see the TupleIsNullPredicate example, since this change did not require changes at that callsite. for, getBoundPredicate-- we'd expect to run some queries that previously would fail the assertion. -- To view, visit http://gerrit.cloudera.org:8080/8783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88153eea9f4b5117df60366fad2bd91776b95298 Gerrit-Change-Number: 8783 Gerrit-PatchSet: 7 Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 17:56:02 +0000 Gerrit-HasComments: Yes
