Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 )
Change subject: IMPALA-6301: Fix test failures when username or group name contains dots ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@155 PS2, Line 155: $GROUP_NAME > It looks like you didn't quote any of the revoke statements. Do > they work without the quotes? I was first confused about that I just need to quote group names in tests/authorization/test_grant_revoke.py, then these tests passed. After that, I dug into the logs and found that the GROUP_NAME used in QueryTest/grant_revoke.test and QueryTest/grant_revoke_kudu.test is "Devs"! This is my first group name printed by command 'groups'. However, the python grp package may use group name in /etc/group in which I have only one group name 'quanlong.huang'. This is the reason why I can run pass tests in QueryTest/grant_revoke.test without some GROUP_NAME quoted. I think we should still quote all the GROUP_NAMEs to prevent tests fail on other developer's machines. http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@494 PS2, Line 494: $GROUP_NAME > quote? Sure, I missed them! -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Dec 2017 00:38:30 +0000 Gerrit-HasComments: Yes
