Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 )
Change subject: IMPALA-5754: Improve randomness of rand()/random() ...................................................................... Patch Set 20: Thanks for the information. I would like to exclude the third party library because the modification of the library seems not to be maintainable and delivery of the modification to the upstream might not be acceptable. When I checked the logs, there are trivial issues only: - warning: 'PCG_USE_ZEROCHECK_ROTATE_IDIOM' is not defined, evaluates to 0 - warning: expansion of date or time macro is not reproducible > I think you may have missed this comment. There were two failed > jobs. You have addressed one of them - thank you! Can you take a > look at the other one? -- To view, visit http://gerrit.cloudera.org:8080/8355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 Gerrit-Change-Number: 8355 Gerrit-PatchSet: 20 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Dec 2017 03:13:19 +0000 Gerrit-HasComments: No
