Hello Jim Apple, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8829 to look at the new patch set (#2). Change subject: IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp ...................................................................... IMPALA-5754: Rollback the exclusion of clang-tidy check for pcg-cpp In the commit 4feb4f3a, the third party library pcg-cpp was excluded from the clang-tidy check. It could make unexpected side effect, so fixing some warnings from clang-tidy is better than avoidance of the check. Change-Id: I591d30373cb13f0eb89afbe16d81b1d3fb783365 --- M be/src/thirdparty/pcg-cpp-0.98/include/pcg_extras.hpp M bin/run_clang_tidy.sh 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/8829/2 -- To view, visit http://gerrit.cloudera.org:8080/8829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I591d30373cb13f0eb89afbe16d81b1d3fb783365 Gerrit-Change-Number: 8829 Gerrit-PatchSet: 2 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>