Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8774 )
Change subject: IMPALA-5014: Part 1: Round when casting string to decimal
......................................................................
Patch Set 3: Code-Review-1
Looks like there's a Python test we need to update...
03:52:25 ] TestDecimalCasting.test_underflow[cast_from: string | decimal_type:
(6, 3) | exec_option: {'decimal_v2': 'true'}]
03:52:25 ] [gw0] linux2 -- Python 2.7.12
/home/ubuntu/Impala/bin/../infra/python/env/bin/python
03:52:25 ] query_test/test_decimal_casting.py:166: in test_underflow
03:52:25 ] self._assert_decimal_result(cast, res, expected_val)
03:52:25 ] query_test/test_decimal_casting.py:80: in _assert_decimal_result
03:52:25 ] assert expected == actual, "Cast: {0}, Expected: {1}, Actual:
{2}".format(cast,\
03:52:25 ] E AssertionError: Cast: select cast('-85.0817' as Decimal(6,3)),
Expected: -85.081, Actual: -85.082
03:52:25 ] E assert Decimal('-85.081') == Decimal('-85.082')
--
To view, visit http://gerrit.cloudera.org:8080/8774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd8b92727fb384e6ff2d145e4aab7ae5d27db26d
Gerrit-Change-Number: 8774
Gerrit-PatchSet: 3
Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Dec 2017 05:54:29 +0000
Gerrit-HasComments: No
