Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8854/2/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/8854/2/be/src/codegen/llvm-codegen.h@497 PS2, Line 497: /// Codegen at the current builder location in function 'fn' to store the : /// max/min('src', value in 'dst_slot_ptr') in 'dst_slot_ptr' > nit, how about: Done http://gerrit.cloudera.org:8080/#/c/8854/2/testdata/workloads/functional-query/queries/QueryTest/aggregation.test File testdata/workloads/functional-query/queries/QueryTest/aggregation.test: http://gerrit.cloudera.org:8080/#/c/8854/2/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@1345 PS2, Line 1345: values (0), (1), (cast('nan' as double) > maybe include inf/-inf Done -- To view, visit http://gerrit.cloudera.org:8080/8854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81 Gerrit-Change-Number: 8854 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2017 22:40:10 +0000 Gerrit-HasComments: Yes
