Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 )
Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock ...................................................................... Patch Set 1: (1 comment) fix looks good to me. just a small ques that I ran into while trying to walk through the code path again that caused this issue. http://gerrit.cloudera.org:8080/#/c/8933/1/be/src/runtime/bufferpool/reservation-tracker.cc File be/src/runtime/bufferpool/reservation-tracker.cc: http://gerrit.cloudera.org:8080/#/c/8933/1/be/src/runtime/bufferpool/reservation-tracker.cc@209 PS1, Line 209: parent_ I think it is possible to get to this point and have parent_ == nullptr steps: if parent_ == nullptr, L195 sets granted = true, then TryConsumeFromMemTracker(reservation_increase) fails at L230 -- To view, visit http://gerrit.cloudera.org:8080/8933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7adbe961a925075422c685690dd3d1609779ced Gerrit-Change-Number: 8933 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Jan 2018 01:03:03 +0000 Gerrit-HasComments: Yes
