Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 )
Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners ...................................................................... Patch Set 2: > Can we test all the cases fixed this with 100% reproducible cases? > For Ex: > I commented out the change in decompress.cc and ran the fuzz test > and it passed. > Can we test all the cases fixed this with 100% reproducible cases? > For Ex: > I commented out the change in decompress.cc and ran the fuzz test > and it passed. If you run a couple of times without the fix the assertion will be hit. I'll see if I can change the test so that we hit the assert every time -- To view, visit http://gerrit.cloudera.org:8080/8936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9cfc38af3f30c65ada9734eb471dbfa6ecdd74a Gerrit-Change-Number: 8936 Gerrit-PatchSet: 2 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Mon, 08 Jan 2018 16:59:34 +0000 Gerrit-HasComments: No