Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#5). Change subject: IMPALA-3193: Show table's comment on show tables ...................................................................... IMPALA-3193: Show table's comment on show tables Currently SHOW TABLES command does not display given comment when creating a table. DESC <table> shows column's comment and SHOW DATABASES also shows database's comment. On this change, table's comment can be displayed if catalog table owns Hive metastore table(HMS) object. There is not any HMS call due to performance concern, so table's comment can be empty even though table has a comment. There is a change in thrift part: a list of table comments is added to TGetTablesResult struct as an optional element. Testing: Adds E2E test. TestShowTables.testTableCommentVisibility Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd --- M be/src/catalog/catalog-server.cc M be/src/service/client-request-state.cc M be/src/service/frontend.cc M be/src/service/frontend.h M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M common/thrift/Frontend.thrift M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java M fe/src/main/java/org/apache/impala/service/MetadataOp.java M tests/query_test/test_queries.py 14 files changed, 149 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/8851/5 -- To view, visit http://gerrit.cloudera.org:8080/8851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd Gerrit-Change-Number: 8851 Gerrit-PatchSet: 5 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com>