Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 )
Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8991/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8991/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC Thanks for the detailed commit message, this is helpful http://gerrit.cloudera.org:8080/#/c/8991/2//COMMIT_MSG@30 PS2, Line 30: FLAGS_TCMALLOC_MAX_TOTAL_THREAD_CAHCE_BYTES typo http://gerrit.cloudera.org:8080/#/c/8991/2/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: http://gerrit.cloudera.org:8080/#/c/8991/2/be/src/runtime/bufferpool/system-allocator.cc@52 PS2, Line 52: MallocExtension::instance()->SetNumericProperty( I think this should be done in InitCommonRuntime() so that we don't have different settings in impalad, statestored and catalogd -- To view, visit http://gerrit.cloudera.org:8080/8991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5be574435af51fb7a875b16888cca260b341190e Gerrit-Change-Number: 8991 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Jan 2018 16:22:09 +0000 Gerrit-HasComments: Yes
