Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 )
Change subject: IMPALA-3526: update FE tests to pass on S3 ...................................................................... Patch Set 4: (1 comment) yes, missed adding the file when renaming. added now. http://gerrit.cloudera.org:8080/#/c/8890/4/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/8890/4/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@132 PS4, Line 132: // Tests queries that are insensitive to all filesystems. > maybe also say "whose plans are insensitive to the underlying filesystem" Done. changed the wording a bit in all places. -- To view, visit http://gerrit.cloudera.org:8080/8890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c8221949e76b0a0b9192e6b56c4da5eeae04141 Gerrit-Change-Number: 8890 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Jan 2018 00:37:07 +0000 Gerrit-HasComments: Yes
