Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9000 )
Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9000/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9000/1//COMMIT_MSG@21 PS1, Line 21: Testing(manual): Changed the core-site.xml to use LDAPGroupsMapping > Can we add a regression test to TestRequestPool? This seems subtle and easy Agree. It doesn't seem easy enough to use LDAPGroupsMapping directly since it requires a valid LDAP URI to work, so I added a test to make sure that the core-site.xml configs are loaded. Please let me know if thats okay -- To view, visit http://gerrit.cloudera.org:8080/9000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb93870c0cc37e2432a643a274931f1d3d13fb96 Gerrit-Change-Number: 9000 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Jan 2018 07:53:11 +0000 Gerrit-HasComments: Yes
