Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 )
Change subject: IMPALA-4993: extend dictionary filtering to collections ...................................................................... Patch Set 11: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8775/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/8775/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1091 PS11, Line 1091: private Map<TupleDescriptor, List<Integer>> PrintDictionaryConjuncts( * return void * the typical pattern we use for explain helper functions is: String getFooBarExplainString(String prefix); see examples like getTableStatsExplainString(), getNodeExplainString() would be good to change this helper to e consistent -- To view, visit http://gerrit.cloudera.org:8080/8775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3a2abcfc3d0f7d18756816659fed77ce12668dd Gerrit-Change-Number: 8775 Gerrit-PatchSet: 11 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Jan 2018 06:09:07 +0000 Gerrit-HasComments: Yes
