Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 )
Change subject: IMPALA-6388: Fix the Union node number of hosts estimation ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9017/1/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test File testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test: http://gerrit.cloudera.org:8080/#/c/9017/1/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test@3563 PS1, Line 3563: select coalesce(int_col, int_col) from functional.alltypes > That's true. In my view having a coalesce in both queries on different oper To me it's easier to reason about if the operands are either all passthrough or none of them are passthrough because if all operands are consistent they will not be reordered. Having a mix of passthrough and non-passthrough means there might be reordering. Also it's not obvious why we have a coalesce() in this test and if we every optimize() coalesce this test might "break". -- To view, visit http://gerrit.cloudera.org:8080/9017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51e1ecca8dbc84b2b5a72708667b2799d00279f0 Gerrit-Change-Number: 9017 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Jan 2018 21:20:32 +0000 Gerrit-HasComments: Yes
