Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 )
Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc@1061 PS1, Line 1061: ImpaladMetrics::CATALOG_CURR_VER->set_value(catalog_update_info_.catalog_version); > Are you sure you don't need the catalog_version_lock_ to access this here? Changed the logic that takes the catalog_version_lock_ to update the newly added metric http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc@1514 PS1, Line 1514: ImpaladMetrics::CATALOG_CURR_VER->set_value(min_req_catalog_version); > I think this may not be necessary? Removed it. http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/util/impalad-metrics.h File be/src/util/impalad-metrics.h: http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/util/impalad-metrics.h@113 PS1, Line 113: CATALOG_CURR_VER > Why not exposing all the information in CatalogUpdateVersionInfo? Good suggestion added a new function CatalogUpdateMetrics in CatalogUpdateVersionInfo -- To view, visit http://gerrit.cloudera.org:8080/8949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97 Gerrit-Change-Number: 8949 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Jan 2018 20:54:18 +0000 Gerrit-HasComments: Yes
