Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9036 )
Change subject: IMPALA-6377: Bump breakpad version to include fix for #752 ...................................................................... Patch Set 1: Code-Review+2 (3 comments) Just a few nits. http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@7 PS1, Line 7: #752 Could you add a link for this? http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@8 PS1, Line 8: Not sure if you do this on every version bump, but it would be good to include a link to the JIRA regarding the DWZ patch, and just say that you're re-applying it for the new version. http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@9 PS1, Line 9: This also removes the PPC patches from Breakpad, which I was not able to : get to apply cleanly. Add that the PPC patch will get re-added in a later commit, after the patch is fixed for the latest version. -- To view, visit http://gerrit.cloudera.org:8080/9036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b Gerrit-Change-Number: 9036 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Jan 2018 21:54:56 +0000 Gerrit-HasComments: Yes
