Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 )
Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps ...................................................................... Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG@10 PS2, Line 10: there was a bug in the retry logic Could you also briefly add what this bug was in the commit message? http://gerrit.cloudera.org:8080/#/c/9079/2//COMMIT_MSG@15 PS2, Line 15: to forget the it typo http://gerrit.cloudera.org:8080/#/c/9079/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/9079/2/tests/query_test/test_observability.py@151 PS2, Line 151: introduce an error below I don't think that it's important to state this line. But if you feel like it's better to keep it, I have a nit: "...introduce an error below in future changes..." -- To view, visit http://gerrit.cloudera.org:8080/9079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0f3db75c52b8b2081dd15ed7e7d2a1d6b22389 Gerrit-Change-Number: 9079 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Jan 2018 22:38:56 +0000 Gerrit-HasComments: Yes
