Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 )
Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions ...................................................................... Patch Set 5: Code-Review+2 (3 comments) Carry +2. http://gerrit.cloudera.org:8080/#/c/9060/4/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: http://gerrit.cloudera.org:8080/#/c/9060/4/be/src/rpc/thrift-server.cc@93 PS4, Line 93: DCHECK_GE(max_supported_tls_version, TLS1_VERSION); > Is it fair to DCHECK_LE(protocol, TLSv1_2_plus) given the way we treat defa Done http://gerrit.cloudera.org:8080/#/c/9060/4/be/src/rpc/thrift-server.cc@99 PS4, Line 99: return protocol != TLSv1_2_plus && protocol != TLSv1_2; > DCHECK_GE(max_supported_tls_version, TLS_1_2_VERSION); Done http://gerrit.cloudera.org:8080/#/c/9060/4/be/src/rpc/thrift-server.cc@102 PS4, Line 102: return true; : } > not needed ? Done -- To view, visit http://gerrit.cloudera.org:8080/9060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd40219b7be5889b3c24457acdb79a28bdcd9bfb Gerrit-Change-Number: 9060 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Jan 2018 22:23:51 +0000 Gerrit-HasComments: Yes
